feat: move serverUrl input from /config to /login dialog#73
Merged
Conversation
Move the server URL configuration field from ConfigDialog to LoginDialog so users can configure and save the server URL directly in the SSO login flow without switching between dialogs. - LoginDialog: replace read-only serverUrl display with editable input + save button that sends updateConfiguration to the backend - ConfigDialog: remove serverUrl field - ChatApp: keep login dialog open on configurationUpdated message - Add CSS for login-serverUrl-row layout - Update and add E2E tests for new behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the server URL configuration field from ConfigDialog to LoginDialog
so users can configure and save the server URL directly in the SSO login
flow without switching between dialogs.
save button that sends updateConfiguration to the backend